fix: align MaxBlobSize with Piri DefaultMaxPaddedSize - #65
Merged
Conversation
This was referenced Sep 1, 2026
bajtos
approved these changes
Sep 3, 2026
pyropy
approved these changes
Sep 3, 2026
alanshaw
added a commit
to fil-forge/piri
that referenced
this pull request
Sep 4, 2026
…drift (#104) Updates assertions to prevent these two constants drifting. Mentioned by Claude which I agree with: > One thing I'd not do is make piri derive its piece config from libforge — the dependency should point one way: libforge states the network constant, piri's default must satisfy it, and the piri test is the guard. Depends on: * fil-forge/libforge#65 refs #49
alanshaw
added a commit
to fil-forge/ingot
that referenced
this pull request
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libforge's network-wide blob ceiling was 268_435_456 (256 MiB raw), but since fil-forge/piri#49 a default-configured piri accepts at most
266,338,304raw bytes per piece (256 MiB padded, ×127/128 Fr32 —piri/pkg/pdp/piecesize). A 256 MiB raw blob pads to a 2^29 piece and is rejected withBlobSizeLimitExceeded, so the constant clients shard against exceeded what every default node accepts.Found by ingot's 5 GiB max-part itest (FIL-495); ingot's own default
max_blob_sizewas fixed separately to sit an envelope allowance under the cap.